Add missing project to wolverine.slnx#2575
Closed
saithis wants to merge 1 commit intoJasperFx:mainfrom
Closed
Conversation
Contributor
Author
|
Without it wolverine doesn't compile, since it can't find the project. |
3 tasks
jeremydmiller
added a commit
that referenced
this pull request
Apr 26, 2026
…ject-in-slnx Add Wolverine.SourceGeneration to slnx (supersedes #2575)
jeremydmiller
added a commit
to rmasciarella/wolverine
that referenced
this pull request
Apr 26, 2026
After JasperFxGH-2575 added Wolverine.SourceGeneration to wolverine.slnx, `dotnet build wolverine.slnx --framework net9.0` started failing with NETSDK1005 because the analyzer project only targets netstandard2.0 (required for Roslyn analyzer loadability). The error doesn't appear in unconstrained builds because the project naturally selects its single TargetFramework, but CI and local commands that pin a framework hit it. The project is already pulled in transitively as an analyzer via Wolverine.csproj's ProjectReference (OutputItemType="Analyzer", ReferenceOutputAssembly="false"), so it gets built whenever Wolverine itself does. Marking it Build="false" in the slnx — same pattern used for build/build.csproj — keeps it visible in the IDE solution view but skips it from solution-level builds, sidestepping the framework resolution mismatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Got it w/ a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.